Plugin corsi blocks issue 141 #142
Open
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility to register the wrong sequence without ending the trial
🦋 Changeset detectedLatest commit: a0d39da The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A changeset for version bump for plugin-corsi-blocks
…nd response in plugin-corsi-blocks
asengupta3
reviewed
Oct 22, 2024
| } else { | ||
| display_element | ||
| .querySelector(`.jspsych-corsi-block[data-id="${id}"]`) | ||
| .animate(incorrect_animation, animation_timing); | ||
| trial_data.correct = false; | ||
| } |
There was a problem hiding this comment.
Thank you @Pavel6625 for working on this? I was about to work on this feature as well. This helps our use case as well. I am wondering if this needs to be an optional feature (turned on or off via a feature flag). The old behavior might still be useful under certain circumstances.
asengupta3
reviewed
Oct 22, 2024
| trial_data.correct = false; | ||
| } | ||
| // Only end the trial when the response length matches the sequence length | ||
| if (trial_data.response.length == trial.sequence.length) { |
There was a problem hiding this comment.
NIT: trial_data.response.length === trial.sequence.length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the updated version of
register_click(), the trial only ends when the response length matches the sequence length, regardless of whether the clicks were correct or not. This allows the user to register an incorrect sequence without ending the trial immediately.